netdev - Re: [PATCH] Packet socket: mmapped IO: PACKET_TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2008 20:19:09 +0100
From:	"Johann Baudy" <johaahn@...il.com>
To:	"Evgeniy Polyakov" <zbr@...emap.net>,
	"David Miller" <davem@...emloft.net>
Cc:	"Lovich, Vitali" <vlovich@...lcomm.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] Packet socket: mmapped IO: PACKET_TX_RING

Hi Evgeniy, David,

> I think you should be almost 200% sure that skb is not allowed to grow up :)
Well! I'm lost :)

How can we forward a pointer from skb allocation to skb destructor
without adding a kind of destructor argument in sk_buff struct?

Thanks in advance,
Johann

On Tue, Nov 11, 2008 at 7:50 PM, Evgeniy Polyakov <zbr@...emap.net> wrote:
> Hi.
>
> On Tue, Nov 11, 2008 at 10:14:54AM -0800, Lovich, Vitali (vlovich@...lcomm.com) wrote:
>> Right, we're saying the exact same thing I think.  I had wanted just a void * that is specific to PACKET_MMAP, so that no one else pays the price if they don't need to.  You instead want to make it a feature flag - that's fine I think, but we need to make a note of that in the Kconfig file (that enabling PACKET_MMAP increases all skbs by the size of a long).  I'd still rather prefer using the fragments instead though, because it seems like a reasonable solution that has 0 impact on any other code.
>
> I think you should be almost 200% sure that skb is not allowed to grow up :)
>
> --
>        Evgeniy Polyakov
>



-- 
Johann Baudy
johaahn@...il.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html