lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Nov 2008 22:04:24 -0800 From: "Tarr, Stephen F" <Stephen.Tarr@...ox.com> To: <netdev@...r.kernel.org> Subject: RE: IPv6 and link state transitions > From: Stephen Hemminger [mailto:shemminger@...tta.com] > Driver should not use set_bit directly. > The correct way for a driver that has carrier to work is > > mydrvr_open(struct net_device *dev) > { > ... > if (mydrv_phy_isoffline(dev)) > netif_carrier_off(dev); > ... > } > > mydrv_phy_intr(...) { > if (mydrv_phy_isoffline(dev)) > netif_carrier_off(dev); > else > netif_carrier_on(dev) > } I actually tried that first, but that led to an extraneous up/down transition during initialization and (at least sometimes) extra packets transmitted after the link came up. Is there some other way to set the initial link state during initialization -- before the NETDEV_UP event is sent and without triggering an extra NETDEV_DOWN? And should it really be the specific mac or phy driver or the generic phy code that sets that state? -Steve Tarr -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists