netdev - Re: [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Nov 2008 14:20:01 -0800
From:	"Jeff Kirsher" <jeffrey.t.kirsher@...el.com>
To:	"Roland Dreier" <rdreier@...co.com>
Cc:	"Patrick McHardy" <kaber@...sh.net>, davem@...emloft.net,
	netdev@...r.kernel.org, jeff@...zik.org,
	"Alexander Duyck" <alexander.h.duyck@...el.com>,
	"Peter P Waskiewicz Jr" <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver

On Fri, Nov 21, 2008 at 9:58 AM, Roland Dreier <rdreier@...co.com> wrote:
>  > > --- /dev/null
>  > > +++ b/net/dcb/Kconfig
>  > > @@ -0,0 +1,12 @@
>  > > +config DCB
>  > > +        tristate "Data Center Bridging support"
>
>  > A help text would be nice to have.
>
> Yes, agreed -- something giving a hint about what DCB is (per-priority
> pause, BCN) and guidance for the user that this should be enabled if
> using DCB-capable NICs and switches.
>
>  > > +
>  > > +config DCBNL
>  > > +  bool "Data Center Bridging netlink interface support"
>  > > +  depends on DCB
>  > > +  default n
>  > > +  ---help---
>  > > +    This option turns on the netlink interface
>  > > +    (dcbnl) for Data Center Bridging capable devices.
>  > > +
>  > > +    If unsure, say N.
>
> Now that I look at this config, it looks rather strange.  When does is
> ever make sense to enable DCB but not DCBNL?  How else does one
> configure all the DCB parameters except by running dcbd in userspace?
> Should there even be a separate DCBNL option at all?
>
>  - R.
> --
>

Thanks for the comments.  I am working on patches based on your
comments and should have something by Monday at the latest.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html