lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 21 Nov 2008 01:21:15 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	jeff@...zik.org, alexander.h.duyck@...el.com,
	peter.p.waskiewicz.jr@...el.com
Subject: Re: [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB
 to the kernel and ixgbe driver

From: Wang Chen <wangchen@...fujitsu.com>
Date: Fri, 21 Nov 2008 17:14:16 +0800

> Jeff Kirsher said the following on 2008-11-21 10:00:
> > diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c b/drivers/net/ixgbe/ixgbe_ethtool.c
> > index a610016..aaa4404 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethtool.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethtool.c
> > @@ -97,9 +97,18 @@ static struct ixgbe_stats ixgbe_gstrings_stats[] = {
> >  	((((struct ixgbe_adapter *)netdev_priv(netdev))->num_tx_queues + \
> >  	((struct ixgbe_adapter *)netdev_priv(netdev))->num_rx_queues) * \
> >  	(sizeof(struct ixgbe_queue_stats) / sizeof(u64)))
> > -#define IXGBE_STATS_LEN (IXGBE_GLOBAL_STATS_LEN + IXGBE_QUEUE_STATS_LEN)
> >  #define IXGBE_GLOBAL_STATS_LEN ARRAY_SIZE(ixgbe_gstrings_stats)
> > -#define IXGBE_STATS_LEN (IXGBE_GLOBAL_STATS_LEN + IXGBE_QUEUE_STATS_LEN)
> > +#define IXGBE_PB_STATS_LEN ( \
> > +                 (((struct ixgbe_adapter *)netdev->priv)->flags & \
> 
> Dave, please don't hate me. :)
> I know you've applied it.
> But I don't want this directly reference of netdev->priv.

Send me a patch!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ