netdev - Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 22 Nov 2008 00:22:14 +0800
From:	"Guo-Fu Tseng" <cooldavid@...ldavid.org>
To:	David Miller <davem@...emloft.net>, shemminger@...tta.com
Cc:	akeem@...cron.com, ethanhsiao@...cron.com, jgarzik@...ox.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH netdev-2.6] jme: JMicron Gigabit Ethernet Driver

On Fri, 21 Nov 2008 00:46:33 -0800 (PST), David Miller wrote
> From: Stephen Hemminger <shemminger@...tta.com>
> Date: Thu, 20 Nov 2008 22:45:42 -0800
> 
> > On Thu, 20 Nov 2008 21:36:27 -0800 (PST)
> > David Miller <davem@...emloft.net> wrote:
> > 
> > > From: Stephen Hemminger <shemminger@...tta.com>
> > > Date: Thu, 20 Nov 2008 21:20:45 -0800
> > > 
> > > > 6. Not using pci dma allocation which is more standard convention
> > > 
> > > Using the generic DMA interfaces is actually preferred.  There is
> > > no effective difference other than using a more generic interface.
> > 
> > Ok, but this???
> 
> Yes, of course, all of those NAPI et al. abstraction macros have
> to go.
> 
> I was only commenting about the DMA bits, the rest of your
> criticism was on target.
Thank you for point those out.
This is my first driver, so I still have many things to learn.
I'll work on it. Any suggestion or help is very welcome!

Guo-Fu Tseng

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html