netdev - Re: [NET-NEXT PATCH 06/14] e1000e: remove unnecessary header file inclusions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Nov 2008 16:53:21 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, jeff@...zik.org, bruce.w.allan@...el.com
Subject: Re: [NET-NEXT PATCH 06/14] e1000e: remove unnecessary header file
 inclusions

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Fri, 21 Nov 2008 11:00:35 -0800

> From: Bruce Allan <bruce.w.allan@...el.com>
> 
> timer.h and workqueue.h do not need to be explicitly included.
> 
> Signed-off-by: Bruce Allan <bruce.w.allan@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

You are using "struct timer_list" et al. in this header file so
you do in fact need to include these header files.

If the idea is to rely upon getting these headers indirectly,
that's not how things work.

Not applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html