netdev - Re: [PATCH] netfilter: nf_conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Nov 2008 13:48:07 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	Wu Fengguang <fengguang.wu@...el.com>
CC:	Wang Chen <wangchen@...fujitsu.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Netfilter Development Mailinglist 
	<netfilter-devel@...r.kernel.org>
Subject: Re: [PATCH] netfilter: nf_conntrack_sctp: fix build warning

Wu Fengguang wrote:
> On Mon, Nov 24, 2008 at 02:23:16PM +0200, Patrick McHardy wrote:
>> +	/* Avoid bogus warning, gcc doesn't realize do_basic_checks()
>> +	 * guarantees that there is at least one SCTP chunk.
>> +	 */
>> +	if (unlikely(new_state == SCTP_CONNTRACK_MAX))
>> +		goto out;
>> +
> 
> If do_basic_checks() guarantees that, why not Initialize new_state to 0?

Good point. I've replaced the patch by this one:


View attachment "x" of type "text/plain" (1261 bytes)