netdev - Re: [PATCH 05/39] wimax: debug macros and debug settings for the WiMAX stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Nov 2008 10:28:08 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Inaky Perez-Gonzalez <inaky@...ux.intel.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 05/39] wimax: debug macros and debug settings for the
	WiMAX stack

On Wed, 2008-11-26 at 15:07 -0800, Inaky Perez-Gonzalez wrote:
> This file contains a simple debug framework that is used in the stack;
                       ^^^^^ ??

> it allows the debug level to be controlled at compile-time (so the
> debug code is optimized out) and at run-time (for what wasn't compiled
> out).

Recently we got new stuff for dynamic printk
(include/linux/dynamic_printk.h) and pr_debug with a start format
(include/linux/kernel.h, pr_fmt); can you use any of that to make this
smaller? If not, I think you ought to argue why not, and possibly
improve the generic facility.

Personally, I'm tired of seeing every Intel driver come with a new huge
set of debugging macros that are barely understandable.

> +#define _d_printf(l, tag, dev, f, a...)					\
> +do {									\
> +	char head[64];							\
> +	if (!d_test(l))							\
> +		break;							\
> +	__d_head(head, sizeof(head), dev);				\
> +	printk(KERN_ERR "%s%s%s: " f, head, __func__, tag, ##a);	\
> +} while (0 && dev)

That && dev is wrong.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)