netdev - Re: [NET-NEXT PATCH] ixgbe: Implement PCIe AER support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Dec 2008 17:47:54 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, jeff@...zik.org,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	linux-pci@...r.kernel.org
Subject: Re: [NET-NEXT PATCH] ixgbe: Implement PCIe AER support

On Mon, 01 Dec 2008 16:41:15 -0800
Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:

> From: PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>
> 
> This patch implements the PCIe Advanced Error Reporting callbacks in
> ixgbe.  The 82598 hardware supports AER, so we enable it.
> 
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---

Once again: pcie-aer is not checking for mmconfig working!
If you turn it on, you may get screaming errors.

pci_enable_pcie_error_reporting should be checking for pci_read/pci_write
config errors and does not.

Your driver should be checking for pci_enable_pcie_error_reporting failing.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html