netdev - Re: [PATCH next] staging-p80211: Kill directly reference of c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 06 Dec 2008 10:28:45 +0800
From:	Wang Chen <wangchen@...fujitsu.com>
To:	Greg KH <gregkh@...e.de>
CC:	"David S. Miller" <davem@...emloft.net>,
	NETDEV <netdev@...r.kernel.org>
Subject: Re: [PATCH next] staging-p80211: Kill directly reference of	c

Greg KH said the following on 2008-12-5 23:44:
> On Fri, Dec 05, 2008 at 11:14:53PM +0800, Wang Chen wrote:
>> In this driver, netdev's private data is wlandevice_t.
>> And the wlandev(type of wlandevice_t) is exist before netdev be allocated.
>> So use netdev->ml_priv to point to the private data.
>>
>> I am not sure whether I should consider the kernel version older than 2.3.38.
>> Because in those kernels, netdevice_t is "structure dev" instead of 
>> "structure net_device" and of course "dev->ml_priv" will cause compile error.
>> But before my patch, in function wlan_setup(), there is a ether_setup(net_device)
>> which already broke kernels which older than 2.3.38.
> 
> Heh, no we only need to support the current mainline kernel with this
> driver, no old 2.3.x versions :)
> 

Thanks for your explanation.

> thanks for the patch, I'll queue it up,
> 

I'm doing this "kill netdev->priv" work on Dave's net-next tree now.
So, will it be better to let Dave apply this to his net-next instead
you apply it?
Just suggestion :)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html