lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Dec 2008 17:21:01 -0600 From: Andy Fleming <afleming@...escale.com> To: jeff@...zik.org Cc: galak@...nel.crashing.org, netdev@...r.kernel.org, Haruki Dai <Dai.Haruki@...escale.com>, Dai Haruki <dai.haruki@...escale.com> Subject: [PATCH v2.6.29 08/14] gianfar: Remove unused gfar_add_fcb() function parameter From: Haruki Dai <Dai.Haruki@...escale.com> - Also, use cacheable_memzero instead of memset for performance reasons. Signed-off-by: Dai Haruki <dai.haruki@...escale.com> Acked-by: Andy Fleming <afleming@...escale.com> --- drivers/net/gianfar.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 21d7acf..6c0e0a3 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -1166,11 +1166,11 @@ static int gfar_enet_open(struct net_device *dev) return err; } -static inline struct txfcb *gfar_add_fcb(struct sk_buff *skb, struct txbd8 *bdp) +static inline struct txfcb *gfar_add_fcb(struct sk_buff *skb) { struct txfcb *fcb = (struct txfcb *)skb_push (skb, GMAC_FCB_LEN); - memset(fcb, 0, GMAC_FCB_LEN); + cacheable_memzero(fcb, GMAC_FCB_LEN); return fcb; } @@ -1233,14 +1233,14 @@ static int gfar_start_xmit(struct sk_buff *skb, struct net_device *dev) /* Set up checksumming */ if (CHECKSUM_PARTIAL == skb->ip_summed) { - fcb = gfar_add_fcb(skb, txbdp); + fcb = gfar_add_fcb(skb); status |= TXBD_TOE; gfar_tx_checksum(skb, fcb); } if (priv->vlgrp && vlan_tx_tag_present(skb)) { if (unlikely(NULL == fcb)) { - fcb = gfar_add_fcb(skb, txbdp); + fcb = gfar_add_fcb(skb); status |= TXBD_TOE; } -- 1.5.4.GIT -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists