netdev - Re: [PATCH] tcp: make urg+gso work for real this time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 18 Dec 2008 10:41:47 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	David Miller <davem@...emloft.net>
Cc:	kuznet@....inr.ac.ru, ptesarik@...e.cz, ilpo.jarvinen@...sinki.fi,
	netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: make urg+gso work for real this time

On Wed, Dec 17, 2008 at 03:34:42PM -0800, David Miller wrote:
>
> > 2) Even if we did this would be broken either way because just
> > where do you put the urgent pointer if your packet is > 64K and
> > the urgent pointer lies in the packet but beyond 64K to the start?
> 
> You would need to chop up the packet to allow proper specification of
> the URG pointer.

Right, and it'd be just as easy to chop up the packet so that we
can set the urgent pointer to 0xffff :)

> I agree that prompt signalling of the URG condition is desirable.
> 
> None of the RFCs seem to give any real guidance in this area, and that
> explains the plethora of ways we see various stacks handling this
> situation.
> 
> I'll think about your patch some more, but no promises.

This is definitely something that we don't want to rush into.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html