lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 18 Dec 2008 22:55:15 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dfoley@...us.net
Cc:	netdev@...r.kernel.org, steve.glendinning@...c.com
Subject: Re: smsc911x unloading crash

From: dfoley <dfoley@...us.net>
Date: Thu, 18 Dec 2008 14:50:34 -0800

> I am testing out the new smsc911x driver that is in the linux-next tree.
> I get a crash when unloading the module. I've got this patch to fix it. I noticed that the dev_set_drvdata is clobbering the data when
> the driver's ..._remove function calls dev = platform_get_drvdata(pdev);
> I've back ported this to run on 2.6.27, so this patch may or
> may not be needed. Sorry if it's a matter of not having the latest version.

Steve, please take a look at this.

dfoley, even if your patch is correct your email client has severely
corrupted the patch (changing tab characters into spaces, etc.) so if
this patch is still needed you'll need to resubmit with your email
client fixed to not corrupt the patch with formatting changes.

> diff -purN a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
> --- a/drivers/net/smsc911x.c    2008-12-18 10:03:27.000000000 -0800
> +++ b/drivers/net/smsc911x.c    2008-12-18 12:03:52.000000000 -0800
> @@ -822,7 +822,6 @@ static int __devinit smsc911x_mii_init(s
>                  pdata->mii_bus->irq[i] = PHY_POLL;
> 
>          pdata->mii_bus->parent = &pdev->dev;
> -       dev_set_drvdata(&pdev->dev, &pdata->mii_bus);
> 
>          pdata->using_extphy = 0;
> 
> @@ -1872,7 +1871,7 @@ static int __devexit smsc911x_drv_remove
>          res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>                                             "smsc911x-memory");
>          if (!res)
> -               platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +               res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> 
>          release_mem_region(res->start, res->end - res->start);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists