netdev - Re: [PATCH 9/9 V2] mlx4_en: Multiqueue support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Dec 2008 18:41:09 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	yevgenyp@...lanox.co.il
Cc:	jeff@...zik.org, rdreier@...co.com, netdev@...r.kernel.org
Subject: Re: [PATCH 9/9 V2] mlx4_en: Multiqueue support

From: Yevgeny Petrilin <yevgenyp@...lanox.co.il>
Date: Mon, 29 Dec 2008 11:57:09 +0200

> Added a function that performs hashing on the TX traffic.
> The hashing is only done for TCP or UDP packets, all other packets
> are sent to a default queue.
> We use an indirection table with an entry for each hash result.
> For each entry in the table, we hold statistics regarding the stream
> that corresponds to that entry. Packets are then directed to a TX queue
> according to stream's pattern.
> A ring is opened for each queue.
> 
> Signed-off-by: Yevgeny Petrilin <yevgenyp@...lanox.co.il>

You are not supposed to provide a driver private function
to hash the traffic.

The generic code already hashes traffic for you, and whatever
it doesn't handle currently will be handled in the future.
The generic code is where gaps should be filled in.

The override function pointer is only for wireless which has
special needs in queue selection that have nothing to do with
flow seperation.

Please resubmit this without your private hashing function.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html