netdev - Re: [PATCH] ibmveth: use consistent types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Dec 2008 21:49:59 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sfr@...b.auug.org.au
Cc:	netdev@...r.kernel.org, linuxppc-dev@...abs.org, santil@...ibm.com
Subject: Re: [PATCH] ibmveth: use consistent types

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Wed, 31 Dec 2008 14:02:25 +1100

> These variables are only used with an interface involving "unsigned
> long" and the macros are only used with these variables.  This change
> will prevent some warnings when we change u64 to "unsigned long long".
> 
> This code is only built for 64bit powerpc, so the transformation is
> really a noop.
> 
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>

I'd prefer if the types were to remain 32-bit portable.

Doing things like this is just a problem waiting to happen,
either for the first person who actually finds a need and
a way to use this driver on 32-bit or the person who cut and
pastes this code into their driver which should work on both
32-bit and 64-bit.

Patch not applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html