netdev - Re: [PATCH] isdn: capi: &&/|| typos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Jan 2009 13:16:30 +0100
From:	Karsten Keil <kkeil@...e.de>
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	kkeil@...e.de, netdev@...r.kernel.org
Subject: Re: [PATCH] isdn: capi: &&/|| typos

On Tue, Dec 30, 2008 at 01:31:38PM +0100, Roel Kluin wrote:
> Correct two typos.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>

Acked-by: Karsten Keil <kkeil@...e.de>

> ---
> diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c
> index d5b4cc3..6501202 100644
> --- a/drivers/isdn/capi/capidrv.c
> +++ b/drivers/isdn/capi/capidrv.c
> @@ -1519,7 +1519,7 @@ static int decodeFVteln(char *teln, unsigned long *bmaskp, int *activep)
>  		int digit2 = 0;
>  		if (!isdigit(*s)) return -3;
>  		while (isdigit(*s)) { digit1 = digit1*10 + (*s - '0'); s++; }
> -		if (digit1 <= 0 && digit1 > 30) return -4;
> +		if (digit1 <= 0 || digit1 > 30) return -4;
>  		if (*s == 0 || *s == ',' || *s == ' ') {
>  			bmask |= (1 << digit1);
>  			digit1 = 0;
> @@ -1530,7 +1530,7 @@ static int decodeFVteln(char *teln, unsigned long *bmaskp, int *activep)
>  		s++;
>  		if (!isdigit(*s)) return -3;
>  		while (isdigit(*s)) { digit2 = digit2*10 + (*s - '0'); s++; }
> -		if (digit2 <= 0 && digit2 > 30) return -4;
> +		if (digit2 <= 0 || digit2 > 30) return -4;
>  		if (*s == 0 || *s == ',' || *s == ' ') {
>  			if (digit1 > digit2)
>  				for (i = digit2; i <= digit1 ; i++)

-- 
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html