lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 05 Jan 2009 13:02:15 -0800 From: Roland Dreier <rdreier@...co.com> To: Stephen Hemminger <shemminger@...tta.com> Cc: David Miller <davem@...emloft.net>, Roland Dreier <rolandd@...co.com>, Sean Hefty <sean.hefty@...el.com>, Hal Rosenstock <hal.rosenstock@...il.com>, netdev@...r.kernel.org, general@...ts.openfabrics.org Subject: Re: [PATCH 7/8] infiniband: driver API update Looks good enough, so Dave if you want to merge it, you can add Acked-by: Roland Dreier <rolandd@...co.com> or let me know if you want me to pull it in through my tree. A couple of nits that are probably not worth fixing. First, globally, it might be slightly nicer to merge this as one patch per module, rather than all lumped together. And also: > +static const struct net_device_ops c2_netdev_ops = { > + .ndo_open = c2_pseudo_up, > + .ndo_stop = c2_pseudo_down, > + .ndo_start_xmit = c2_pseudo_xmit_frame, > + .ndo_change_mtu = c2_pseudo_change_mtu, > +}; > + > + would have preferred only one empty line here. > @@ -735,7 +737,6 @@ static void setup(struct net_device *net > netdev->addr_len = ETH_ALEN; > netdev->tx_queue_len = 0; > netdev->flags |= IFF_NOARP; > - return; > } > > static struct net_device *c2_pseudo_netdev_init(struct c2_dev *c2dev) would preferred to leave out unrelated changes. > +static const struct net_device_ops nes_netdev_ops = { > + .ndo_open = nes_netdev_open, > + .ndo_stop = nes_netdev_stop, > + .ndo_start_xmit = nes_netdev_start_xmit, > + .ndo_get_stats = nes_netdev_get_stats, > + .ndo_tx_timeout = nes_netdev_tx_timeout, > + .ndo_validate_addr = eth_validate_addr, > + .ndo_set_mac_address = nes_netdev_set_mac_address, > + .ndo_set_multicast_list = nes_netdev_set_multicast_list, > + .ndo_change_mtu = nes_netdev_change_mtu, > + .ndo_vlan_rx_register = nes_netdev_vlan_rx_register, > +}; > + > > /** extra blank line here too. - R. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists