lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 08 Jan 2009 13:29:57 +0000 From: Ben Hutchings <bhutchings@...arflare.com> To: Oliver Hartkopp <oliver@...tkopp.net> Cc: Stephen Hemminger <shemminger@...tta.com>, Linux Netdev List <netdev@...r.kernel.org> Subject: Re: dev->get_stats(dev) in COMPAT_NET_DEV_OPS case On Thu, 2009-01-08 at 14:12 +0100, Oliver Hartkopp wrote: > Hello Stephen, > > in commit eeda3fd64f75bcbfaa70ce946513abaf3f23b8e0 ("netdev: introduce > dev_get_stats() > <http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commit;h=eeda3fd64f75bcbfaa70ce946513abaf3f23b8e0>") > you remove the setting of dev->get_stats : > > @@ -4370,7 > <http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=blob;f=net/core/dev.c;h=ca14ab407b338172758bc409efd2baaf75bdee99;hb=d314774cf2cd5dfeb39a00d37deee65d4c627927#l4370> > +4384,6 > <http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=blob;f=net/core/dev.c;h=8843f4e3f5e192eba9eb5154faa1ca4131fb01fc;hb=eeda3fd64f75bcbfaa70ce946513abaf3f23b8e0#l4384> > @@ struct net_device *alloc_netdev_mq(int sizeof_priv, const char *name, > > netdev_init_queues(dev); > > - dev->get_stats = internal_stats; > netpoll_netdev_init(dev); > setup(dev); > strcpy(dev->name, name); > > I really appreciate your introduction of COMPAT_NET_DEV_OPS but when i > try to compile and run a non-converted driver, i get a NULL pointer > dereference. I tracked it down to be the call of dev->get_stats(dev). > > Did you miss something or is this behaviour intended? You should be calling dev_get_stats() now. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists