netdev - Re: [RFC 0/4] net namespace for PPP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Jan 2009 00:27:00 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	davem@...emloft.net, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, devel@...nvz.org, xemul@...nvz.org
Subject: Re: [RFC 0/4] net namespace for PPP

On Fri, Jan 09, 2009 at 10:51:54PM +0300, Cyrill Gorcunov wrote:
> here is a series of RFC in attempt to implement
> net-namespaces for PPP protocol (including PPPoE
> and PPPoL2TP).

You need assign netns to netdevice after alloc_netdev().
This should fix much confusion and non-bugs mentioned in this thread.

After that struct ppp shouldn't need netns pointer as it will be netns
of it's netdevice.

current->nsproxy->net_ns while being correct in ioctl context
(it's synchronous) is easy to screwup. For example, in netfilter code netns
is taken from socket on which ioctl is done.

Regardless of netns, try_module_get() calls by hand are suspicious
and they're copied to netns init hook.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html