netdev - Re: [PATCH v2] powerpc/fs_enet: Add missing irq free in error path.

Open Source and information security mailing list archives

Date:	Tue, 13 Jan 2009 10:28:15 -0600
From:	Kumar Gala <galak@...nel.crashing.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org,
	linuxppc-dev list <linuxppc-dev@...abs.org>,
	Mike Ditto <mditto@...sentry.com>
Subject: Re: [PATCH v2] powerpc/fs_enet: Add missing irq free in error path.

On Oct 27, 2008, at 4:46 PM, Mike Ditto wrote:

> If something goes wrong attaching to phy driver, we weren't freeing
> the IRQ.
>
> Signed-off-by: Mike Ditto <mditto@...sentry.com>
> ---
> Reposting to CC netdev list.  (Thanks, Kumar)
>
> diff -r -upN 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c NEW/ 
> drivers/net/fs_enet/fs_enet-main.c
> --- 2.6.28-rc1/drivers/net/fs_enet/fs_enet-main.c	2008-10-24  
> 17:54:31.000000000 -0700
> +++ NEW/drivers/net/fs_enet/fs_enet-main.c	2008-10-24  
> 17:57:03.000000000 -0700
> @@ -795,6 +795,7 @@ static int fs_enet_open(struct net_devic
>
> 	err = fs_init_phy(dev);
> 	if (err) {
> +		free_irq(fep->interrupt, dev);
> 		if (fep->fpi->use_napi)
> 			napi_disable(&fep->napi);
> 		return err;
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...abs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

Dave,

This seems to have gotten lost in the shuffle.  Can you please apply.

- k
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives