netdev - Re: [PATCH] fec: use linux/*.h instead of asm/*.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Jan 2009 13:55:12 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Sascha Hauer <s.hauer@...gutronix.de>
CC:	netdev@...r.kernel.org, Sebastian Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH] fec: use linux/*.h instead of asm/*.h

Hi Sacha,

Sascha Hauer wrote:
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> ---

No problems with this either for ColdFire,

Acked-by:  Greg Ungerer <gerg@...inux.org>



>  drivers/net/fec.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/fec.c b/drivers/net/fec.c
> index 812d8be..1a07d56 100644
> --- a/drivers/net/fec.c
> +++ b/drivers/net/fec.c
> @@ -36,15 +36,13 @@
>  #include <linux/spinlock.h>
>  #include <linux/workqueue.h>
>  #include <linux/bitops.h>
> +#include <linux/io.h>
> +#include <linux/irq.h>
>  
> -#include <asm/irq.h>
> -#include <asm/uaccess.h>
> -#include <asm/io.h>
> -#include <asm/pgtable.h>
>  #include <asm/cacheflush.h>
> -
>  #include <asm/coldfire.h>
>  #include <asm/mcfsim.h>
> +
>  #include "fec.h"
>  
>  #if defined(CONFIG_FEC2)

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear, a McAfee Company                  PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html