netdev - Re: cxgb3: Replace LRO with GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 17 Jan 2009 16:08:39 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Divy Le Ray <divy@...lsio.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Steve Wise <swise@...ngridcomputing.com>
Subject: Re: cxgb3: Replace LRO with GRO

Hi Divy:

On Fri, Jan 16, 2009 at 03:12:07AM -0800, Divy Le Ray wrote:
>
>        1.112500  __alloc_skb                         vmlinux

Can you confirm that you were testing 1500 byte packets?  If so
that would tell us why this function got up there.  As it stands
GRO will not stop aggregating even when the frags array is full,
until the skb size hits 64K.

That means half the packet will be in frag_list which is very
inefficient.

If this is indeed the problem, then for now I'll simply make
it stop aggregating after the array is full, just like LRO.

While in future we can extend it such that even when it starts
using frag_list, it'll still continue to fill in the frags array.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html