netdev - Re: cxgb3: Replace LRO with GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Jan 2009 09:50:40 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Divy Le Ray <divy@...lsio.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Steve Wise <swise@...ngridcomputing.com>
Subject: Re: cxgb3: Replace LRO with GRO

On Sun, Jan 18, 2009 at 12:33:42PM -0800, Divy Le Ray wrote:
> 
> Thanks for the patch. It does improve the performance.
> I'm now getting about 5.3Gbs.

Thanks for testing Divy!

> Here is a oprofile output:
>       33.929900  copy_user_generic_unrolled          vmlinux
>        7.150300  process_responses                  cxgb3.ko
>        6.261100  refill_fl                          cxgb3.ko
>        6.181700  memcpy                              vmlinux

I wonder why this is still up there.

Maybe this patch will help?

diff --git a/net/core/dev.c b/net/core/dev.c
index 3742397..3cc19fa 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2554,7 +2554,8 @@ struct sk_buff *napi_fraginfo_skb(struct napi_struct *napi,
 
 	BUG_ON(info->nr_frags > MAX_SKB_FRAGS);
 	skb_shinfo(skb)->nr_frags = info->nr_frags;
-	memcpy(skb_shinfo(skb)->frags, info->frags, sizeof(info->frags));
+	memcpy(skb_shinfo(skb)->frags, info->frags,
+	       info->nr_frags * sizeof(*info->frags));
 
 	skb->data_len = info->len;
 	skb->len += info->len;

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html