| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Jan 2009 09:53:54 +0000 From: Steve.Glendinning@...c.com To: Russell King - ARM Linux <linux@....linux.org.uk> Cc: David Miller <davem@...emloft.net>, ian.saturley@...c.com, linux-arm-kernel@...ts.arm.linux.org.uk, netdev@...r.kernel.org, "stanley.miao" <stanley.miao@...driver.com> Subject: Re: [PATCH REPOST 0/5] convert arm platforms to smsc911x Russell King - ARM Linux <linux@....linux.org.uk> wrote on 19/01/2009 09:22:57: > On Mon, Jan 19, 2009 at 04:04:34PM +0800, stanley.miao wrote: > > On Sun, 2009-01-18 at 21:53 -0800, David Miller wrote: > > > I've applied patches 1 and 2, the smsc911x driver changes. > > > > > > I can pull the platform changes into net-next-2.6 as well > > > if people don't think there will enough conflicts to cause > > > problems. > > > > I think the platform data had better stay in arm tree. > > What would be the impact if patches 3 to 5 got merged before 1 and 2? It would not break compilation, but it would probably break ethernet support on those three platforms. All 3 platforms pass some combination of IRQF_TRIGGER_LOW | IRQF_SHARED when registering these interrupts. The trigger flag isn't passed through without 1 and IRQF_SHARED isn't specified without 2. I expect register_irq would fail on these platforms without these flags? Steve -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists