netdev - Re: [patch 2.6.29-rc] usbnet: allow type check of devdbg arguments in non-debug build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Jan 2009 17:57:30 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	david-b@...bell.net
Cc:	netdev@...r.kernel.org, steve.glendinning@...c.com,
	ian.saturley@...c.com, jeff@...zik.org
Subject: Re: [patch 2.6.29-rc] usbnet: allow type check of devdbg arguments
 in non-debug build

From: David Miller <davem@...emloft.net>
Date: Mon, 19 Jan 2009 17:12:00 -0800 (PST)

> From: David Brownell <david-b@...bell.net>
> Date: Fri, 16 Jan 2009 23:19:44 -0800
> 
> > Improve usbnet's devdbg to always type-check diagnostic arguments,
> > like dev_dbg (device.h).  This makes no change to the resulting size of
> > usbnet modules.
> > 
> > Signed-off-by: Steve Glendinning <steve.glendinning@...c.com>
> > Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>
> 
> Applied, thanks.

I have to back this out, it breaks the build:

drivers/net/wireless/rndis_wlan.c: In function 'rndis_translate_scan':
drivers/net/wireless/rndis_wlan.c:1664: error: 'usbdev' undeclared (first use in this function)
drivers/net/wireless/rndis_wlan.c:1664: error: (Each undeclared identifier is reported only once
drivers/net/wireless/rndis_wlan.c:1664: error: for each function it appears in.)
make[3]: *** [drivers/net/wireless/rndis_wlan.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/net/wireless] Error 2
make[2]: *** Waiting for unfinished jobs....

I bet there are other similar gremlins like this in the tree.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html