netdev - Re: [RFT 2/4] netfilter: remove unneeded initializations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Jan 2009 03:10:32 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	David Miller <davem@...emloft.net>,
	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: [RFT 2/4] netfilter: remove unneeded initializations

On Tue, Jan 27, 2009 at 03:53:12PM -0800, Stephen Hemminger wrote:
> Later patches change the locking on xt_table and the initialization of
> the lock element is not needed since the lock is always initialized in
> xt_table_register anyway.

>  net/ipv4/netfilter/arptable_filter.c   |    2 --
>  net/ipv4/netfilter/iptable_filter.c    |    1 -
>  net/ipv4/netfilter/iptable_mangle.c    |    1 -
>  net/ipv4/netfilter/iptable_raw.c       |    1 -
>  net/ipv4/netfilter/iptable_security.c  |    1 -
>  net/ipv4/netfilter/nf_nat_rule.c       |    1 -
>  net/ipv6/netfilter/ip6table_filter.c   |    1 -
>  net/ipv6/netfilter/ip6table_mangle.c   |    1 -
>  net/ipv6/netfilter/ip6table_raw.c      |    1 -
>  net/ipv6/netfilter/ip6table_security.c |    1 -
>  10 files changed, 11 deletions(-)
> 
> --- a/net/ipv4/netfilter/arptable_filter.c
> +++ b/net/ipv4/netfilter/arptable_filter.c
> @@ -48,8 +48,6 @@ static struct
>  static struct xt_table packet_filter = {
>  	.name		= "filter",
>  	.valid_hooks	= FILTER_VALID_HOOKS,
> -	.lock		= __RW_LOCK_UNLOCKED(packet_filter.lock),

ACK and you can do the same for ebt_register_table() users.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html