netdev - Re: [PATCH] smsc911x: timeout reaches -1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Jan 2009 15:22:03 +0000
From:	Steve.Glendinning@...c.com
To:	Roel Kluin <roel.kluin@...il.com>
Cc:	netdev@...r.kernel.org, Ian.Saturley@...c.com
Subject: Re: [PATCH] smsc911x: timeout reaches -1

Roel Kluin <roel.kluin@...il.com> wrote on 29/01/2009 15:12:03:

> With a postfix decrement the timeout will reach -1 rather than 0,
> so the warning will not be issued.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c
> index f513bdf..783c1a7 100644
> --- a/drivers/net/smsc911x.c
> +++ b/drivers/net/smsc911x.c
> @@ -953,7 +953,7 @@ smsc911x_rx_fastforward(struct smsc911x_data 
> *pdata, unsigned int pktbytes)
>        do {
>           udelay(1);
>           val = smsc911x_reg_read(pdata, RX_DP_CTRL);
> -      } while (timeout-- && (val & RX_DP_CTRL_RX_FFWD_));
> +      } while (--timeout && (val & RX_DP_CTRL_RX_FFWD_));
> 
>        if (unlikely(timeout == 0))
>           SMSC_WARNING(HW, "Timed out waiting for "

Thanks for spotting this Roel.

Acked-by: Steve Glendinning <steve.glendinning@...c.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html