lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 31 Jan 2009 01:44:16 +0100 From: Ingo Molnar <mingo@...e.hu> To: "Rafael J. Wysocki" <rjw@...k.pl> Cc: Parag Warudkar <parag.lkml@...il.com>, Linus Torvalds <torvalds@...ux-foundation.org>, Matt Carlson <mcarlson@...adcom.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: 2.6.29-rc3: tg3 dead after resume * Rafael J. Wysocki <rjw@...k.pl> wrote: > +static struct dev_pm_ops pcie_portdrv_pm_ops = { > + .suspend = pcie_port_device_suspend, > + .resume = pcie_port_device_resume, > + .freeze = pcie_port_device_suspend, > + .thaw = pcie_port_device_resume, > + .poweroff = pcie_port_device_suspend, > + .restore = pcie_port_device_resume, > +}; pet peeve: could we please use vertical spaces wherever they improve the code? Something like: static struct dev_pm_ops pcie_portdrv_pm_ops = { .suspend = pcie_port_device_suspend, .resume = pcie_port_device_resume, .freeze = pcie_port_device_suspend, .thaw = pcie_port_device_resume, .poweroff = pcie_port_device_suspend, .restore = pcie_port_device_resume, }; ... and it all becomes clear at a glance. Please? Ingo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists