[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 02 Feb 2009 08:10:04 -0600
From: Anthony Liguori <anthony@...emonkey.ws>
To: Rusty Russell <rusty@...tcorp.com.au>
CC: Alex Williamson <alex.williamson@...com>, markmc@...hat.com,
netdev@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH v3 1/4] virtio_net: Add a virtqueue for outbound control
commands
Hi Alex,
Can you post the userspace side of this to qemu-devel (against QEMU SVN)
and I'll review/apply. I've already looked through the series a couple
times and I don't think there are any major issues.
Regards,
Anthony Liguori
Rusty Russell wrote:
> On Monday 02 February 2009 06:35:10 Alex Williamson wrote:
>
>
>> +static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,
>> + struct scatterlist data[], int out, int in)
>> +{
>> + struct scatterlist sg[VIRTIO_NET_MAX_CTRL_ARGS];
>>
> ...
>
>> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h
>> index f76bd4a..f28a72a 100644
>> --- a/include/linux/virtio_net.h
>> +++ b/include/linux/virtio_net.h
>>
> ...
>
>> +#define VIRTIO_NET_MAX_CTRL_ARGS 2
>>
>
> I think this definition belongs at the top of virtio_net.c; the others
> are userspace-exposed, this is really an internal issue, no?
>
> Other than that, you can add Acked-by: Rusty Russell <rusty@...tcorp.com.au>
> and send to netdev for DaveM's tree.
>
> Thanks!
> Rusty.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists