netdev - Re: [PATCH] sungem: limit reaches -1, but 0 tested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 02 Feb 2009 23:19:59 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	roel.kluin@...il.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sungem: limit reaches -1, but 0 tested

From: Roel Kluin <roel.kluin@...il.com>
Date: Sun, 01 Feb 2009 18:15:27 +0100

> while (limit--)
> 	if (test())
> 		break;
> 
> if (limit <= 0)
> 	goto test_failed;
> 
> In the last iteration, limit is decremented after the test to 0.
> If just thereafter test() succeeds and a break occurs, the goto
> still occurs because limit is 0.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>

Also applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html