lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 3 Feb 2009 23:12:09 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: Evgeniy Polyakov <zbr@...emap.net> Cc: Jarek Poplawski <jarkao2@...il.com>, David Miller <davem@...emloft.net>, w@....eu, dada1@...mosbay.com, ben@...s.com, mingo@...e.hu, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, jens.axboe@...cle.com Subject: Re: [PATCH v2] tcp: splice as many packets as possible at once On Tue, Feb 03, 2009 at 03:07:15PM +0300, Evgeniy Polyakov wrote: > > How many? A hundred or so descriptors (or even several thousands) - > this really does not scale for the somewhat loaded IO servers, that's > why we frequently get questions why dmesg is filler with order-3 and > higher allocation failure dumps. I think you've misunderstood my suggested scheme. I'm suggesting that we keep the driver initialisation path as is, so however many skb's the driver is allocating at open() time remains unchanged. Usually this would be the number of entries on the ring buffer. We can't do any better than that since if the hardware can't do SG then you'll just have to find this many contiguous buffers. The only change we need to make is at receive time. Instead of always pushing the received skb into the stack, we should try to allocate a linear replacement skb, and if that fails, allocate a fragmented skb and copy the data into it. That way we can always push a linear skb back into the ring buffer. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists