lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Feb 2009 09:16:06 +0200 From: Risto Suominen <risto.suominen@...il.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: jgarzik@...ox.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Grant Grundler <grundler@...isc-linux.org> Subject: Re: [PATCH 002/002] de2104x: support for systems lacking cache coherence 2009/2/10 Andrew Morton <akpm@...ux-foundation.org>: > > Please prefer to prepare patches in `patch -p1' form: > > --- a/drivers/net/tulip/Kconfig > +++ a/drivers/net/tulip/Kconfig > I'll try to remember that. > I think CONFIG_DE2104X_DSL is always defined if this driver is being > compiled. So the Kconfig `default' should suffice here? In which case > we can do > > #define DSL CONFIG_DE2104X_DSL > > and leave it at that. > > In which case we can do away with DSL everywhere and just use > CONFIG_DE2104X_DSL here. > I was thinking of the case where someone just compiles without reconfiguring. > But really, we shouldn't do this at configuration time at all. It > would be much better to do it at runtime, via a module parameter. > Well, yeah, but that would probably cost cpu cycles. At least it would mean lots of changes. > And it would be much^2 better to do it automatically, based upon the > chip probing information or whatever. That's probably hard. > I agree. > Can remove the ifdefs here. A zero-length array is OK, and will > consume zero space. > I was uncertain whether this applies to all compilers. I kind of remember opposite cases in the past. Risto -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists