lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 15 Feb 2009 17:07:12 +0100 From: Roel Kluin <roel.kluin@...il.com> To: chas@....nrl.navy.mil CC: netdev@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org> Subject: [PATCH] ATM: misplaced parentheses? I think below is what was intended? otherwise we could as well have written: tmp = (lanai->conf1 & ~CONFIG1_PROMDATA) || (data & i) ? CONFIG1_PROMDATA : 0; Does this fix the parsing of the EEPROM? please review. -------------------------->8------------------8<--------------------------- Fix misplaced parentheses Signed-off-by: Roel Kluin <roel.kluin@...il.com> --- diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c index 144a49f..317fb5a 100644 --- a/drivers/atm/lanai.c +++ b/drivers/atm/lanai.c @@ -901,7 +901,7 @@ static int __devinit eeprom_read(struct lanai_dev *lanai) clock_l(); udelay(5); for (i = 128; i != 0; i >>= 1) { /* write command out */ tmp = (lanai->conf1 & ~CONFIG1_PROMDATA) | - (data & i) ? CONFIG1_PROMDATA : 0; + (data & i ? CONFIG1_PROMDATA : 0); if (lanai->conf1 != tmp) { set_config1(tmp); udelay(5); /* Let new data settle */ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists