netdev - Re: LRO restructuring?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Feb 2009 22:20:53 +0000 (UTC)
From:	James Huang <jamesclhuang@...il.com>
To:	netdev@...r.kernel.org
Subject:  Re: LRO restructuring?


Hi all,
 
    One question about inet_lro.c (linux 2.6.28.6)
In lro_proc_segment(), it does not check the number of available frags entries 
in lro_desc->parent against the number of new fragments to be added before 
calling lro_add_frags().  Is that a bug?  I see that lro_proc_segment() does 
some type of checking at the end, but could that be too late (i.e. overflow 
the frags[])??
 
    Also I think some obvious optimization in lro_get_desc() can be done by 
combining the two for loops into one.
 
-- James Huang




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html