[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 22 Feb 2009 08:19:47 +0000
From: Russell King - ARM Linux <linux@....linux.org.uk>
To: David Miller <davem@...emloft.net>
Cc: linux-arm-kernel@...ts.arm.linux.org.uk, netdev@...r.kernel.org,
shemminger@...tta.com
Subject: Re: Yet more fixes to etherh.c
On Sat, Feb 21, 2009 at 11:44:48PM -0800, David Miller wrote:
> From: Russell King - ARM Linux <linux@....linux.org.uk>
> Date: Sat, 21 Feb 2009 19:36:33 +0000
>
> > Further to a71558d, this is round five of fixes to make etherh work
> > again. As mainline kernels stand, the fixes in b9a9b4b were the wrong
> > approach.
> ...
> > Fix up b9a9b4b by making etherh's net_device_ops refer to the internal
> > lib8390 functions, and remove the build of the ISA 8390.c driver.
> >
> > Signed-off-by: Russell King <rmk+kernel@....linux.org.uk>
>
> Applied to net-next-2.6, thanks Russell.
>
> You mention this as a fix against mainline, but your patch
> only applied to net-next-2.6 because the "eth_set_mac_addr"
> fix to this driver only exists there.
Hmm, I don't see the problem. What's currently in mainline is:
.ndo_set_mac_address = eth_mac_addr,
which is what's in the context lines of this patch. I pushed this
myself in a71558d.
> Let me know if you want me to propagate both changes to net-2.6
> and push to Linus.
Definitely, these patches are fixing regressions, so should be submitted
to Linus for 2.6.29.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists