lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 02 Mar 2009 02:56:19 -0500 From: David Dillow <dave@...dillows.org> To: David Miller <davem@...emloft.net> Cc: ben@...adent.org.uk, netdev@...r.kernel.org Subject: Re: [PATCH v2] typhoon: Use request_firmware() On Sun, 2009-03-01 at 20:29 -0800, David Miller wrote: > I cared enough to fix this, maybe one of you will care enough > to test it. Like I said, I will be happy to test as soon as I can dig the hardware out. In any event, this is broken. > static int > typhoon_request_firmware(struct typhoon *tp) > @@ -1367,12 +1368,22 @@ typhoon_request_firmware(struct typhoon *tp) > memcmp(typhoon_fw->data, "TYPHOON", 8)) { > printk(KERN_ERR "%s: Invalid firmware image\n", > tp->name); > - release_firmware(typhoon_fw); > - typhoon_fw = NULL; > - return -EINVAL; > + err = -EINVAL; > + goto out_err; > + } > + > + typhoon_fw_image = kmalloc(typhoon_fw->size, GFP_KERNEL); > + if (!typhoon_fw_image) { > + err = -ENOMEM; > + goto out_err; > } You never copied the image into the kmalloc'd memory, so you upload garbage. Fix that and I think it will be OK. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists