netdev - Re: [net-next PATCH v2] igb: remove skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 02 Mar 2009 16:02:01 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	alexander.h.duyck@...el.com, mitch.a.williams@...el.com
Subject: Re: [net-next PATCH v2] igb: remove skb_orphan calls

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Mon, 02 Mar 2009 15:44:04 -0800

> From: Alexander Duyck <alexander.h.duyck@...el.com>
> 
> Remove skb_orphan call from igb driver as it can cause multiple issues due
> to the fact that it is calling the desctructor and removing the skb from
> the socket prior to transmission.
> 
> The call was added to improve performance but did so by allowing the skb to
> be removed from the socket which gave the socket more window space to
> transmit.  The performance gain is not worth the extra problems that this
> kind of workaround can introduce as this could lead to a potential DoS if a
> UDP stream decided to monopolize the transmit path.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> Acked-by: Mitch Williams <mitch.a.williams@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html