lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 8 Mar 2009 11:57:36 +0100 From: "Rafael J. Wysocki" <rjw@...k.pl> To: Yinghai Lu <yinghai@...nel.org> Cc: Jesse Brandeburg <jesse.brandeburg@...il.com>, David Miller <davem@...emloft.net>, Ingo Molnar <mingo@...e.hu>, Andrew Morton <akpm@...ux-foundation.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, NetDev <netdev@...r.kernel.org> Subject: Re: [PATCH] igb: fix kexec with igb On Saturday 07 March 2009, Yinghai Lu wrote: > On Fri, Mar 6, 2009 at 11:18 PM, Jesse Brandeburg > <jesse.brandeburg@...il.com> wrote: > > On Fri, Mar 6, 2009 at 8:33 PM, Yinghai Lu <yinghai@...nel.org> wrote: > >> > >> Impact: could probe igb > >> > >> Found one system with 82575EB, in the kernel that is kexeced, probe igb > >> failed with -2. > >> > >> it looks like the same behavior happened on forcedeth. > >> > >> try to check system_state to make sure if put it on D3 > >> > >> Signed-off-by: Yinghai Lu <yinghai@...nel.org> > >> > >> --- > >> drivers/net/igb/igb_main.c | 19 ++++++++++++++----- > >> 1 file changed, 14 insertions(+), 5 deletions(-) > > > > I see the point of the patch, but I know for a fact that ixgbe when > > enabled for MSI-X also doesn't work with kexec. > > > > so my questions are: > > are you going to change every driver? > > i tend to only change driver that i have related HW. > > > why can't this be fixed in core kernel code instead? > will check it. > > > Shouldn't pci_enable_device take it out of D3? > > Or maybe it should be taken out of D3 immediately if someone tries to > > ioremap any of the BARx registers? > > > looks like second kernel can not detect the state any more. In fact pci_enable_device() calls pci_set_power_state(dev, PCI_D0) as the first thing. The question is why it doesn't work as expected. What kernel(s) have you tested? Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists