netdev - Re: [net-next PATCH0/12] qlge: More features and cleanup.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Mar 2009 04:46:03 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ron.mercer@...gic.com
Cc:	netdev@...r.kernel.org, linux-driver@...gic.com
Subject: Re: [net-next PATCH0/12] qlge: More features and cleanup.

From: Ron Mercer <ron.mercer@...gic.com>
Date: Mon,  9 Mar 2009 13:59:16 -0700

> Attached are more qlge patches for adding features such as multi TXQ and
> LRO.
> I've also included 4 bug fixes, 3 of which I will also post to net-2.6
> in a separate series tomorrow.

All applied, thanks Ron, although one thing I think you should
get rid of:

> @@ -3354,6 +3351,7 @@ static int ql_configure_rings(struct ql_adapter *qdev)
>  	 * completion handler rx_rings.
>  	 */
>  	qdev->rx_ring_count = qdev->tx_ring_count + qdev->rss_ring_count + 1;
> +	netif_set_gso_max_size(qdev->ndev, 65536);
>  
>  	for (i = 0; i < qdev->tx_ring_count; i++) {
>  		tx_ring = &qdev->tx_ring[i];

65536 (defined by GSO_MAX_SIZE) is the default and it's really a good
idea to only use this override interface on chips that actaully have
restrictions and can't use the default.

I also don't see what this change had to do with adding TX
multiqueue support :-)  It wasn't mentioned in the commit log
message in any way either.  Please don't slip small things in
like this.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html