lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Mar 2009 17:59:30 +1030 From: Rusty Russell <rusty@...tcorp.com.au> To: Pantelis Koukousoulas <pktoss@...il.com> Cc: netdev@...r.kernel.org Subject: Re: [PATCH] Make virtio_net support carrier detection On Wednesday 11 March 2009 22:27:22 Pantelis Koukousoulas wrote: > For now the semantics are simple: There is always carrier. > > This allows a seamless experience with e.g., qemu/kvm > where NetworkManager just configures and sets up > everything automagically. So, NetworkManager ignores the device because it doesn't support carrier detection? That seems weird, but I have nothing against this patch in general. Thanks, Rusty. > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -612,6 +612,7 @@ static struct ethtool_ops virtnet_ethtool_ops = { > .set_tx_csum = virtnet_set_tx_csum, > .set_sg = ethtool_op_set_sg, > .set_tso = ethtool_op_set_tso, > + .get_link = ethtool_op_get_link, > }; > > #define MIN_MTU 68 > @@ -739,6 +740,8 @@ static int virtnet_probe(struct virtio_device *vdev) > goto unregister; > } > > + netif_carrier_on(dev); > + > pr_debug("virtnet: registered device %s\n", dev->name); > return 0; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists