netdev - Re: [PATCH] phylib: convert state_queue work to delayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 13 Mar 2009 15:41:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	khali@...ux-fr.org
Cc:	marcin.slusarz@...il.com, netdev@...r.kernel.org,
	afleming@...escale.com, tpiepho@...escale.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phylib: convert state_queue work to delayed_work

From: Jean Delvare <khali@...ux-fr.org>
Date: Sat, 7 Mar 2009 10:46:20 +0100

> On Fri, 6 Mar 2009 21:51:42 +0100, Marcin Slusarz wrote:
> > It closes a race in phy_stop_machine when reprogramming of phy_timer
> > (from phy_state_machine) happens between del_timer_sync and cancel_work_sync.
> > 
> > Without this change it could lead to crash if phy_device would be freed after
> > phy_stop_machine (timer would fire and schedule freed work).
> > 
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
> > Cc: Andy Fleming <afleming@...escale.com>
> > Cc: Trent Piepho <tpiepho@...escale.com>
> > ---
> > 
> > This patch was only compile tested.
> 
> Patch looks good.
> 
> Acked-by: Jean Delvare <khali@...ux-fr.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html