netdev - Re: [patch 0/6] netfilter: ctnetlink allocation improvement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Mar 2009 10:07:56 +0100
From:	Florian Westphal <fw@...len.de>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	Holger Eitzenberger <holger@...zenberger.org>,
	David Miller <davem@...emloft.net>,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [patch 0/6] netfilter: ctnetlink allocation improvement

Patrick McHardy <kaber@...sh.net> wrote:
>> +	l3proto = nf_ct_l3proto_find_get(tuple->src.l3num);
>> +	len += l3proto->nla_size;
>> +	nf_ct_l3proto_put(l3proto);
>> +
>> +	l4proto = nf_ct_l4proto_find_get(tuple->src.l3num, tuple->dst.protonum);
>> +	len += l4proto->nla_size;
>> +	nf_ct_l4proto_put(l4proto);
>> +
>> +	return alloc_skb(len, gfp);
>
> Its preferrable not to use module reference counting during packet
> processing, the protocols can be accessed safely using RCU. I thought
> I had fixed all those areas, but I now notice that ctnetlink is full
> of similar spots and takes and drops module references quite
> excessively. So just leave it as it is I guess, this should be fully
> fixed anyways.

I'll look into converting all those spots to RCU.

Thanks, Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html