netdev - RE: GRO with non napi driver: BUG in __napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Mar 2009 08:49:10 -0700
From:	Jean-Pascal Billaud <billaud@...are.com>
To:	Frank Blaschka <blaschka@...ux.vnet.ibm.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:	David Miller <davem@...emloft.net>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: RE: GRO with non napi driver: BUG in __napi_complete

More generally, is there still a point to support non-napi drivers? Shouldn't we have a unique way to process traffic at the driver level?

--jp

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of Frank Blaschka
> Sent: Tuesday, March 17, 2009 1:35 AM
> To: netdev@...r.kernel.org
> Cc: David Miller; Herbert Xu
> Subject: GRO with non napi driver: BUG in __napi_complete
> 
> Hi,
> 
> I try to activate GRO on a non napi driver (2.6.29-rc8). Running an
> iperf test
> causes a bug in __napi_complete.
> 
> kernel BUG at net/core/dev.c:2625!
> illegal operation: 0001 <DD>#1<A8> PREEMPT SMP
> Modules linked in:
> CPU: 1 Not tainted 2.6.29-rc8-00124-g5bee17f #8
> Process swapper (pid: 0, task: 000000002ff7ccc0, ksp: 000000002ff97d48)
> Krnl PSW : 0404d00180000000 00000000002d1f4e
> (__napi_complete+0x82/0x88)
>            R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:3 CC:1 PM:0 EA:3
> ...
> <DD>  261.377396<A8> Call Trace:
> <DD>  261.377400<A8> (<DD><00000000002cb752><A8>
> process_backlog+0xba/0x104)
> <DD>  261.377410<A8>  <DD><00000000002cb5ba><A8>
> net_rx_action+0x102/0x1e0
> <DD>  261.377418<A8>  <DD><000000000004921e><A8>
> __do_softirq+0x92/0x168
> <DD>  261.377428<A8>  <DD><0000000000020936><A8> do_softirq+0x96/0xb0
> <DD>  261.377436<A8>  <DD><00000000000493c0><A8> irq_exit+0x70/0x80
> <DD>  261.377444<A8>  <DD><000000000025789c><A8> do_IRQ+0x174/0x194
> <DD>  261.377455<A8>  <DD><00000000000258da><A8> io_return+0x0/0x8
> <DD>  261.377464<A8>  <DD><00000000000246fe><A8>
> vtime_stop_cpu+0xb2/0xc0
> <DD>  261.377473<A8> (<DD><00000007005b1007><A8> 0x7005b1007)
> 
> What is the intention process_backlog calls __napi_complete() instead
> of
> napi_complete(), this looks suspicious to me. Can anybody help?
> 
> Thanks,
> 
> Frank
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html