netdev - Re: iproute2: prints bogus hoplimit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Mar 2009 16:29:28 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Jan Engelhardt <jengelh@...ozas.de>
Cc:	Stephen Hemminger <stephen.hemminger@...tta.com>,
	netdev@...r.kernel.org
Subject: Re: iproute2: prints bogus hoplimit

On Wed, 18 Mar 2009 23:35:12 +0100 (CET)
Jan Engelhardt <jengelh@...ozas.de> wrote:

> 
> On Wednesday 2009-03-18 23:12, Stephen Hemminger wrote:
> >On Tue, 24 Feb 2009 11:27:52 +0100 (CET)
> >Jan Engelhardt <jengelh@...ozas.de> wrote:
> >
> >> $ ip -6 r
> >> fc00::/7 dev rtl0  proto kernel  metric 256  mtu 1500 advmss 1440 
> >> hoplimit 4294967295
> >> 
> >> Most likely, "hoplimit -1" would be the right number, though I am not 
> >> sure if simply changing %u by %d is a correct thing to do, since it 
> >> would affect all fields.
> >> 
> >> ---
> >>  ip/iproute.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>  	if (i != RTAX_RTT && i != RTAX_RTTVAR &&
> >>  	    i != RTAX_RTO_MIN)
> >> -		fprintf(fp, " %u", *(unsigned*)RTA_DATA(mxrta[i]));
> >> +		fprintf(fp, " %d", *(unsigned*)RTA_DATA(mxrta[i]));
> >
> >No fix the kernel please.
> >
> And what should the kernel return?

The issue is that the hoplimit metric in ipv6 gets converted
to -1 (if it is zero on the incoming route request)..  

int ip6_route_add(struct fib6_config *cfg)
{
...
	  if (dst_metric(&rt->u.dst, RTAX_HOPLIMIT) == 0)
                rt->u.dst.metrics[RTAX_HOPLIMIT-1] = -1;


What should happen is when ip6 returns the route back
on the dump request (rt6_fill_node), it should translate the -1 back to 0
to keep it symmetrical and logical. The metrics are unsigned.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html