netdev - Re: [PATCH] tulip: fix crash on iface up with shirq debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Mar 2009 18:49:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kyle@...radead.org
Cc:	netdev@...r.kernel.org, grundler@...isc-linux.org, davej@...hat.com
Subject: Re: [PATCH] tulip: fix crash on iface up with shirq debug

From: Kyle McMartin <kyle@...radead.org>
Date: Sun, 15 Mar 2009 01:35:52 -0400

> Tulip is currently doing request_irq before it has done its
> initialization. This is usually not a problem because it hasn't
> enable interrupts yet, but with DEBUG_SHIRQ on, we call the irq handler
> when registering the interrupt as a sanity check.
> 
> This can result in a NULL ptr dereference, so call tulip_init_ring
> before request_irq, and add a free_ring function to do the freeing
> now shared with tulip_close.
> 
> Tested with a shell loop running ifup, ifdown in a loop a few hundred
> times with DEBUG_SHIRQ on.
> 
> Signed-off-by: Kyle McMartin <kyle@...hat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html