netdev - Re: Fw: [PATCH] ucc_geth: Correct fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Mar 2009 21:46:13 +0100
From:	Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
To:	avorontsov@...mvista.com
Cc:	leoli@...escale.com, linuxppc-dev@...abs.org,
	netdev@...r.kernel.org
Subject: Re: Fw: [PATCH] ucc_geth: Correct fixed_link OOPS.

Anton Vorontsov <avorontsov@...mvista.com> wrote on 20/03/2009 21:07:40:
> 
> On Fri, Mar 20, 2009 at 08:43:56PM +0100, Joakim Tjernlund wrote:
> > hmm, this mail didn't seem to reach the lists. Resending
> > 
> >  Jocke
> > ----- Forwarded by Joakim Tjernlund/Transmode on 20/03/2009 20:42 
-----
> > 
> > From:
> > Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
> > To:
> > leoli@...escale.com, netdev@...r.kernel.org, linuxppc-dev@...abs.org
> > Cc:
> > Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
> > Date:
> > 20/03/2009 18:01
> > Subject:
> > [PATCH] ucc_geth: Correct fixed_link OOPS.
> > 
> > 
> > 
> > fixed_link(PHY less) mode will get you an NULL
> > deference as it does not have a phy-handle.
> > Correct by using already probed information.
> > 
> > Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>
> > ---
> > 
> > The below fixes the problem and seems like the right thing to do.
> > Can we have this in 2.6.29?
> > 
> >  drivers/net/ucc_geth.c |   17 +----------------
> >  1 files changed, 1 insertions(+), 16 deletions(-)

[SNIP]

> 
> This effectivly breaks boards where Gianfar is using UCC's MDIO
> bus (i.e. breaks commit b1c4a9dddf09fe99b8f88252718ac5b357363dc4,
> which is the cause of fixed-link breakage, btw). And, your patch
> is line-wrapped and tabs are substituted by white spaces...

Yes, I noticed that afterwards. It is our "great" new mailsystem
that gets in the way. I really need to find another mailsystem as
Lotus/Domino gets in my way too often :(

> 
> I would suggest something along these lines (unfortunately
> right now I can't test it on real HW, only compile-tested):

Tested here, works fine for fixed-link PHYs, thanks.
I left the 
    priv->oldlink = 0;
    priv->oldspeed = 0;
    priv->oldduplex = -1;
in though. Seemed like a good idea.

Tested By: Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>

 Jocke

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html