netdev - Re: [PATCH] smsc9420: fix big endian rx checksum offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Mar 2009 01:15:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	steve.glendinning@...c.com
Cc:	netdev@...r.kernel.org, ian.saturley@...c.com
Subject: Re: [PATCH] smsc9420: fix big endian rx checksum offload

From: Steve Glendinning <steve.glendinning@...c.com>
Date: Thu, 19 Mar 2009 11:12:32 +0000

> The cpu_to_le16 here looks suspicious to me, I don't think we need it
> because put_unaligned_le16 also does this.
> 
> I don't currently have any big endian hardware with a PCI bus available
> to test on, so I haven't been able to verify this.
> 
> Signed-off-by: Steve Glendinning <steve.glendinning@...c.com>

Looks good, applied.

skb->csum is never unaligned so you probably want to also
convert this to use one of the aligned endianness store
interfaces.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html