netdev - Re: [PATCH] hso: add Vendor/Product ID's for new devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 01 Apr 2009 11:43:58 +0300
From:	Paulius Zaleckas <paulius.zaleckas@...tonika.lt>
To:	Jan Dumon <j.dumon@...ion.com>
CC:	linux-usb@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] hso: add Vendor/Product ID's for new devices

Jan Dumon wrote:
> Paulius Zaleckas wrote:
>> Jan Dumon wrote:
>>> From: Jan Dumon <j.dumon@...ion.com>
>>>
>>> Add Vendor/Product ID's for new devices.
>>>
>>> Signed-off-by: Jan Dumon <j.dumon@...ion.com>
>>> ---
>>> diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
>>> index fe98aca..d47c508 100644
>>> --- a/drivers/net/usb/hso.c
>>> +++ b/drivers/net/usb/hso.c
>>> @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
>>>  	{USB_DEVICE(0x0af0, 0x7701)},
>>>  	{USB_DEVICE(0x0af0, 0x7801)},
>>>  	{USB_DEVICE(0x0af0, 0x7901)},
>>> -	{USB_DEVICE(0x0af0, 0x7361)},
>>> -	{USB_DEVICE(0x0af0, 0xd057)},
>> Please add comment in description why you are removing these IDs.
> 
> No ID's are removed.
> 0xd057 is added again by the same patch, 0x7361 was twice in the list.

OK for 0xd057, but please add comment that you are removing duplicate
definition of 0x7361.

> 
>>> +	{USB_DEVICE(0x0af0, 0x8200)},
>>> +	{USB_DEVICE(0x0af0, 0x8201)},
>>> +	{USB_DEVICE(0x0af0, 0xd035)},
>>>  	{USB_DEVICE(0x0af0, 0xd055)},
>>> +	{USB_DEVICE(0x0af0, 0xd155)},
>>> +	{USB_DEVICE(0x0af0, 0xd255)},
>>> +	{USB_DEVICE(0x0af0, 0xd057)},
>>> +	{USB_DEVICE(0x0af0, 0xd157)},
>>> +	{USB_DEVICE(0x0af0, 0xd257)},
>>> +	{USB_DEVICE(0x0af0, 0xd357)},
>>>  	{}
>>>  };
>>>  MODULE_DEVICE_TABLE(usb, hso_ids);
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html