netdev - Re: [PATCH] i.MX31: Fixing cs89x0 network building to i.MX31ADS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 02 Apr 2009 11:23:19 +0200
From:	Gilles Chanteperdrix <gilles.chanteperdrix@...il.com>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	Sajith P V <sajithpv@...il.com>,
	Alan Carvalho de Assis <acassis@...il.com>,
	linux-arm-kernel@...ts.arm.linux.org.uk, netdev@...r.kernel.org,
	Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [PATCH] i.MX31: Fixing cs89x0 network building to i.MX31ADS

Russell King - ARM Linux wrote:
> On Wed, Apr 01, 2009 at 05:24:27PM +0530, Sajith P V wrote:
>> Hi Alan,
>>
>> On Tue, Mar 31, 2009 at 7:06 PM, Alan Carvalho de Assis
>> <acassis@...il.com> wrote:
>>> This is a fix to get cs89x0 network driver working on i.MX31ADS
>>> diff --git a/drivers/net/cs89x0.c b/drivers/net/cs89x0.c
>>> index ff64976..8ccc8f7 100644
>>> --- a/drivers/net/cs89x0.c
>>> +++ b/drivers/net/cs89x0.c
>>> @@ -190,6 +190,7 @@ static unsigned int cs8900_irq_map[] =
>>> {IRQ_IXDP2X01_CS8900, 0, 0, 0};
>>>  static unsigned int netcard_portlist[] __used __initdata =
>>> {CIRRUS_DEFAULT_BASE, 0};
>>>  static unsigned int cs8900_irq_map[] = {CIRRUS_DEFAULT_IRQ, 0, 0, 0};
>>>  #elif defined(CONFIG_MACH_MX31ADS)
>>> +#include <mach/hardware.h>
>>>  #include <mach/board-mx31ads.h>
>>>  static unsigned int netcard_portlist[] __used __initdata = {
>>>        PBC_BASE_ADDRESS + PBC_CS8900A_IOBASE + 0x300, 0
>>>
>> I tried this change on a different Freescale board but using the same
>> ethernet controller. The probe worked as shown in the console dump
>> below:
> 
> It didn't - you didn't read all the messages.
> 
>> cs89x0:cs89x0_probe(0x0)
>> cs89x0.c: v2.4.3-pre1 Russell Nelson <nelson@...nwr.com>, Andrew
>> Morton <andrewm@....edu.au>
>> eth0: cs8900 rev K found at 0xf0000300
>> cs89x0: Extended EEPROM checksum bad and no Cirrus EEPROM, relying on
>> command line
>> cs89x0 media  IRQ 61, programmed I/O, MAC 00:00:00:00:00:00
>> cs89x0_probe1() successful
>> cs89x0:cs89x0_probe(0x0)
>> cs89x0: request_region(0xf0000300, 0x10) failed
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
>> cs89x0: no cs8900 or cs8920 detected.  Be sure to disable PnP with SETUP
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> The IO region was not available for whatever reason.  Check what's in
> /proc/ioports and also check your setting for IO_SPACE_LIMIT.

That is the expected behaviour of this driver:
http://lists.arm.linux.org.uk/lurker/message/20080917.154011.4631d62b.en.html

I guess the real issue is the failing eeprom and the missing mac address.

-- 
                                                 Gilles.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html