[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sat, 04 Apr 2009 16:37:18 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: jeffrey.t.kirsher@...el.com
Cc: netdev@...r.kernel.org, gospo@...hat.com,
jesse.brandeburg@...el.com, daveboutcher@...il.com
Subject: Re: [PATCH] e1000: fix loss of multicast packets
From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 02 Apr 2009 19:00:32 -0700
> e1000 (and e1000e, igb, ixgbe, ixgb) all do a series of
> operations each time a multicast address is added. The flow goes
> something like
>
> 1) stack adds one multicast address
> 2) stack passes whole current list of unicast and multicast
> addresses to driver
> 3) driver clears entire list in hardware
> 4) driver programs each multicast address using iomem in a loop
>
> This was causing multicast packets to be lost during the
> reprogramming process.
>
> reference with test program:
> http://kerneltrap.org/mailarchive/linux-netdev/2009/3/14/5160514/thread
>
> Thanks to Dave Boutcher for his report and test program.
>
> This driver fix prepares an array all at once in memory and
> programs it in one shot to the hardware, not requiring an "erase"
> cycle.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists